[wasm][coreclr] Fix prestub of methods with IL helper stubs#124873
Merged
radekdoulik merged 6 commits intodotnet:mainfrom Feb 27, 2026
Merged
[wasm][coreclr] Fix prestub of methods with IL helper stubs#124873radekdoulik merged 6 commits intodotnet:mainfrom
radekdoulik merged 6 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a WASM/CoreCLR interpreter prestub issue where methods implemented via managed IL helper stubs could end up publishing an entrypoint that maps to the helper MethodDesc, breaking MethodDesc lookups and access checks (manifesting as MethodAccessException, e.g. around delegate construction).
Changes:
- Update
MethodDesc::DoPrestub(FCall + managed-impl + portable entrypoints) to publish this method’s ownPortableEntryPointand attach interpreter data to it, instead of reusing the helper’s portable entrypoint. - Enable interpreter callsite access-check callouts on WASM by removing the
#ifndef TARGET_WASMguard.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/coreclr/vm/prestub.cpp |
Publishes the current method’s portable entrypoint and sets interpreter data for managed FCall helper-stub scenarios. |
src/coreclr/interpreter/compiler.cpp |
Enables emitting callsite access-check callouts on WASM by removing a WASM-only compile-time exclusion. |
jkotas
reviewed
Feb 26, 2026
jkotas
reviewed
Feb 26, 2026
jkotas
reviewed
Feb 26, 2026
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This was referenced Feb 26, 2026
Open
jkotas
reviewed
Feb 27, 2026
jkotas
approved these changes
Feb 27, 2026
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #121955